Skip to content

Fallback to new Reaper when reused Reaper is unreachable#1233

Merged
cristianrgreco merged 1 commit intomainfrom
codex/reaper-reuse-fallback-1025
Feb 17, 2026
Merged

Fallback to new Reaper when reused Reaper is unreachable#1233
cristianrgreco merged 1 commit intomainfrom
codex/reaper-reuse-fallback-1025

Conversation

@cristianrgreco
Copy link
Collaborator

@cristianrgreco cristianrgreco commented Feb 17, 2026

Summary of changes

  • Make Reaper reuse best-effort: if connecting to a discovered running Reaper fails, try other candidates and then create a new Reaper in the same lock cycle.
  • Update Reaper discovery to return all running candidates and prefer newer ones first.
  • Add a regression test that simulates an unreachable reused Reaper and verifies fallback creation of a new Reaper.

Verification commands run

  • npm run format
  • npm run lint
  • npm run test -- packages/testcontainers/src/reaper/reaper.test.ts

Test results summary

  • packages/testcontainers/src/reaper/reaper.test.ts: 1 file passed, 9 tests passed.

Closes #1025

@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 91b59af
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69947553809a5a0008a1b158
😎 Deploy Preview https://deploy-preview-1233--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Feb 17, 2026
@cristianrgreco cristianrgreco merged commit d75a4ac into main Feb 17, 2026
340 checks passed
@cristianrgreco cristianrgreco deleted the codex/reaper-reuse-fallback-1025 branch February 17, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reaper closes connection but doesn't recover

1 participant