Skip to content

Restore compose warning test compile after naming simplification#1239

Merged
cristianrgreco merged 1 commit intomainfrom
codex/fix-composecontainername-compile
Feb 17, 2026
Merged

Restore compose warning test compile after naming simplification#1239
cristianrgreco merged 1 commit intomainfrom
codex/fix-composecontainername-compile

Conversation

@cristianrgreco
Copy link
Collaborator

Summary of changes

  • Replace a stale composeContainerName("container") reference in the compose warning test with the v2 container name "container-1".
  • Remove the compile regression on main where packages/testcontainers failed with TS2304: Cannot find name 'composeContainerName'.

Verification commands run

  • npm run format
  • npm run lint
  • npm run test -- packages/testcontainers/src/docker-compose-environment/docker-compose-environment.test.ts -t "should warn when no started containers match configured wait strategy names"
  • npm run build --ignore-scripts --workspace packages/testcontainers -- --project tsconfig.json

Test results summary

  • Format and lint completed cleanly.
  • Targeted compose warning test passed.
  • packages/testcontainers compile check passed.

Non-breaking evidence

  • Change is test-only and replaces one unresolved identifier with a concrete container name.
  • No runtime/package code paths or public API exports were changed.

Closes #1238

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Feb 17, 2026
@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit e606043
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6994c26569b3230008343a69
😎 Deploy Preview https://deploy-preview-1239--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added maintenance Improvements that do not change functionality and removed bug Something isn't working labels Feb 17, 2026
@cristianrgreco cristianrgreco merged commit ecd83c8 into main Feb 17, 2026
339 checks passed
@cristianrgreco cristianrgreco deleted the codex/fix-composecontainername-compile branch February 17, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments