Skip to content

Reset stateful regex log waits between matches#1352

Merged
cristianrgreco merged 2 commits into
mainfrom
codex/reset-log-wait-regex-state
Jun 7, 2026
Merged

Reset stateful regex log waits between matches#1352
cristianrgreco merged 2 commits into
mainfrom
codex/reset-log-wait-regex-state

Conversation

@cristianrgreco

Copy link
Copy Markdown
Collaborator

Summary

  • reset regular expression cursor state before matching container log lines
  • strengthen restart coverage with a global regular expression
  • document the red-green-refactor workflow for future bug regression tests in AGENTS.md

Verification

  • red: temporarily removed the implementation fix and ran npm test -- packages/testcontainers/src/wait-strategies/log-wait-strategy.test.ts -t "should wait for a new log after restart"; it failed after restart with Log stream ended and message "/Ready/g" was not received
  • green: restored the fix and reran npm test -- packages/testcontainers/src/wait-strategies/log-wait-strategy.test.ts -t "should wait for a new log after restart"; it passed
  • npm run format
  • npm run lint
  • npm run check-compiles
  • git diff --check

Compatibility

This is a backward-compatible bug fix. String and non-stateful regular expression waits are unchanged.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Jun 1, 2026 — with ChatGPT Codex Connector
@netlify

netlify Bot commented Jun 1, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 2df8860
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6a25707cc81f8f0008ac9362
😎 Deploy Preview https://deploy-preview-1352--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco merged commit 4ad504f into main Jun 7, 2026
517 of 519 checks passed
@cristianrgreco cristianrgreco deleted the codex/reset-log-wait-regex-state branch June 7, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant