Skip to content

Fix Couchbase service configuration#1356

Merged
cristianrgreco merged 3 commits into
mainfrom
codex/fix-couchbase-service-configuration
Jun 7, 2026
Merged

Fix Couchbase service configuration#1356
cristianrgreco merged 3 commits into
mainfrom
codex/fix-couchbase-service-configuration

Conversation

@cristianrgreco

Copy link
Copy Markdown
Collaborator

Summary

  • expose Couchbase service ports at startup after builder customization is complete
  • poll Query readiness for bucket creation only when the Query service is enabled
  • add observable regressions for Enterprise Analytics startup and KV-only bucket usage

Verification

  • npm test -- packages/modules/couchbase/src/couchbase-container.test.ts -t "should start with analytics service enabled"
  • npm test -- packages/modules/couchbase/src/couchbase-container.test.ts -t "should create and use a bucket with KV service only"
  • npm run format
  • npm run lint
  • npm run check-compiles
  • git diff --check

Test results

  • Red: Enterprise Analytics startup failed with No port binding found for :8095/tcp because optional service ports were selected before builder customization.
  • Red: KV-only bucket startup timed out on /query/service after 30000ms because the Query readiness poll was guarded by KV instead of Query.
  • Green: both focused Docker-backed regressions passed concurrently after the fix.

Full Couchbase suite note

A local full concurrent run started all eight Couchbase integration cases together and hit existing Couchbase bootstrap contention: Enterprise cases failed during rebalance and with a closed socket. The focused regressions were rerun concurrently and passed. No suite-level serialization change is included.

Compatibility

This is a backward-compatible bug fix. Existing builder APIs are unchanged. Configured optional services now expose their required ports, and KV-only configurations no longer require the Query service.

@netlify

netlify Bot commented Jun 1, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 9a725ae
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6a25703798c50900089d386b
😎 Deploy Preview https://deploy-preview-1356--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Jun 1, 2026 — with ChatGPT Codex Connector

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0da14f407

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/modules/couchbase/src/couchbase-container.ts
@cristianrgreco cristianrgreco merged commit a1b87ed into main Jun 7, 2026
516 of 519 checks passed
@cristianrgreco cristianrgreco deleted the codex/fix-couchbase-service-configuration branch June 7, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant