feat: update to Angular 21 (and switch to Vitest) #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
force-pushed
the
ng-21
branch
6 times, most recently
from
5feeb13 to
3b712f1
Compare
timdeschryver
commented
Dec 15, 2025
| try { | ||
| const appRef = fixture.componentRef.injector.get(ApplicationRef); | ||
| if (!appRef.destroyed) { | ||
| fixture.changeDetectorRef.markForCheck(); |
Member
Author
There was a problem hiding this comment.
markForCheck is added here for non-signal based properties that are updated (in zoneless applications).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes:
wait-forfixture needed to be updated to use Signals to preventExpressionChangedAfterItHasBeenCheckedErrorwait-for-element-to-be-removedfixture needed to be updated to use Signals to preventExpressionChangedAfterItHasBeenCheckedErrorfakeAsynctest needed to be removed because it requires zone.jsdefertest on click needed to usescreen.findByTextafter a click instead ofscreen.getByTextCloses #524