fix(Pagination): single-page pagination bug#1679
Conversation
Resolves themesberg#1048: Pagination component was incorrectly hiding the '1' button when totalPages=1 due to a hardcoded clamping logic.
|
@JessenReinhart is attempting to deploy a commit to the Bergside Team on Vercel. A member of the Team first needs to authorize it. |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdates pagination page-range handling for small totals by clamping the upper bound and rendering all pages directly when ChangesPagination Range Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add JSDoc to DefaultPagination and TablePagination components - Resolves CI docstring coverage warning
Fixes issue #1048 where pagination failed to render a single page. Includes regression test.
Summary by CodeRabbit
1.