feat: Add support for device code grant#229
Conversation
chalasr
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you rebase it? Here are some comments also
|
Hi @chalasr I'm not entirely sure I understood correctly what you wanted for the docs/device-code-grant.md improvements, but I tried my best to fit to your feedback :) PR is rebased ! |
|
Interested in this PR, but there's been no activity for a few months. Anything we can do to help? |
|
+1 interested as well ! |
ajgarlag
left a comment
There was a problem hiding this comment.
Thank you for your work here. I've managed to create a working demo. I've reviewed your code and added some suggestions.
|
Happy to merge once Antonio's review comments are resolved. |
|
@SimonVanacco Friendly ping |
|
Hi @ajgarlag Thank you for the review, and sorry for the delay. The past few weeks have been a bit hectic :) I implemented some of your requests (new configuration options, refactoring of the repository) and left comments on the ones I won't be able to do myself without some guidance : Supporting Symfony routes for the verification_uri and removing approveDeviceCode. Let me know your thoughts on the update and I'll try to be quicker to respond now ! |
|
Thanks. Supporting route names can be done in a follow-up PR, no problem. Regarding |
|
@SimonVanacco can you look into last comments sometime? |
2071145 to
2166526
Compare
|
@SimonVanacco Thanks for your work here. I've sent a few final suggestions. |
The latest commit should address your suggestions, thank you for the thorough review ! |
ajgarlag
left a comment
There was a problem hiding this comment.
@SimonVanacco Great work! Could you please squash your commits?
@chalasr Would you like to do a final review?
|
Commits squashed :) |
|
Great job! Thank you @SimonVanacco 🚀 |
This PR adds support for device code grants, which has been available for some time in oauth2-server
Ready to be tested, I'd love to get some feedback if you think some areas could be improved !
Design considerations