feat: minimal sandbox support in remote execution - #3520
Open
njskalski wants to merge 4 commits into
Open
Conversation
sean-
reviewed
Apr 15, 2026
added 2 commits
May 12, 2026 17:17
Adds the missing section in config.html for the new Sandbox.Remote field so that //docs/test:docs_test passes.
Contributor
Author
|
@sean- @toastwaffle Hi. I have addressed all comments you made. The feature is gated behind non-default setting. Can we merge it? |
peterebden
reviewed
Aug 12, 2026
peterebden
left a comment
peterebden
left a comment
Collaborator
There was a problem hiding this comment.
Pretty late on this one but it looks interesting...
I think the expectation here is that the remote worker will have the sandbox tool available? That is probably not unreasonable.
FWIW the approach we tool is that the remote workers always sandbox actions according to their own policies (and they know about the SANDBOX env var for some things), but that does require them to cooperate more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am using a custom sandbox and remote execution. This is a minimal patch that enables just that.
I believe most people have a separate profile for remote execution, where they can disable sandbox to keep the old semantics if desired.