Skip to content

SCAL-304157 getcurrentlbexport he#490

Open
yinstardev wants to merge 2 commits intomainfrom
SCAL-304157
Open

SCAL-304157 getcurrentlbexport he#490
yinstardev wants to merge 2 commits intomainfrom
SCAL-304157

Conversation

@yinstardev
Copy link
Copy Markdown
Contributor

No description provided.

@yinstardev yinstardev requested a review from a team as a code owner March 31, 2026 09:38
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the response structure for the GetExportRequestForCurrentPinboard event in the UIPassthroughContractBase to include a nested data object and a type field. Unit tests have been updated to align with this new structure. Feedback suggests enhancing type safety by using the specific UIPassthroughEvent enum value for the type property instead of a generic string.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@490

commit: 4989a8d

@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts bot commented Mar 31, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant