feat(optimizer)!: Annotate ISINF(expr) for DuckDB#6894
Merged
georgesittas merged 3 commits intotobymao:mainfrom Jan 30, 2026
Merged
feat(optimizer)!: Annotate ISINF(expr) for DuckDB#6894georgesittas merged 3 commits intotobymao:mainfrom
ISINF(expr) for DuckDB#6894georgesittas merged 3 commits intotobymao:mainfrom
Conversation
geooo109
approved these changes
Jan 30, 2026
Comment on lines
+21
to
+26
| **{ | ||
| expr_type: {"returns": exp.DataType.Type.BOOLEAN} | ||
| for expr_type in { | ||
| exp.IsInf, | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
This should be in the base annotator, not here. It applies generally AFAICT.
VaggelisD
reviewed
Jan 30, 2026
Collaborator
VaggelisD
left a comment
There was a problem hiding this comment.
Let's also remove it from BigQuery's type annotator given that we moved this to base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR annotate
isinf(expr)for DuckDB asBOOLEANOfficial documentation:
https://duckdb.org/docs/stable/sql/functions/numeric#isinfx