feat: add domain, URL and email validators#2167
Open
seladb wants to merge 2 commits intotortoise:developfrom
Open
feat: add domain, URL and email validators#2167seladb wants to merge 2 commits intotortoise:developfrom
seladb wants to merge 2 commits intotortoise:developfrom
Conversation
Contributor
Author
|
@abondar MSSQL tests are failing again 😕 |
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new validators:
DomainNameValidator,URLValidator, andEmailValidatorheavily inspired by the corresponding Django validatorsDescription
Added three new validator classes:
DomainNameValidator- Validates domain names according to RFC 1034 and RFC 1123accept_idnaparameterInvalidDomainNameexception classURLValidator- Validates URLs according to RFC 3986InvalidURLandInvalidSchemeexception classesEmailValidator- Validates email addresses according to RFC 3696allowed_domainsparameterInvalidEmailAddressexception classAlso added:
validate_domain_name,validate_url,validate_emailMotivation and Context
Provides built-in validators for common validation patterns (domain names, URLs, email addresses) that can be used in tortoise-orm field validators.
Also in par with Django validators.
How Has This Been Tested?
pytest tests/test_validators.pycovering valid and invalid inputs for all three validatorsChecklist: