Remove deprecated upload_records method from qdrant instrumentor - #4357
Remove deprecated upload_records method from qdrant instrumentor#4357DresdenGman wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Qdrant instrumentation removes ChangesQdrant instrumentation updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi! A gentle follow-up on this small Qdrant compatibility fix. The deprecated upload_records mapping and its remaining wrapper branch have been removed for both sync and async clients. All automated checks are green; happy to adjust anything if needed. Thanks for taking a look. |
The
upload_recordsmethod was removed fromqdrant-client1.16.0, causingAttributeErrorduring instrumentation. This PR removes it from both sync and asyncqdrant_client_methods.jsonfiles and cleans up the corresponding dead branch inwrapper.py.Fixes #3492
Summary by CodeRabbit
upload_recordsoperations.