feat(sdk): allow disabling metrics programmatically - #4381
Draft
LuisFigueroaG wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metrics_enabledargument toTraceloop.init()TRACELOOP_METRICS_ENABLEDNoneRoot cause
Metric export and several bundled instrumentations previously read
TRACELOOP_METRICS_ENABLEDdirectly, so applications could not disable metrics through the Python API. Disabling only the SDK metric exporter would also leave instrumentations initialized with metrics enabled.The effective value is now resolved before tracer and instrumentation setup. Explicit values are exposed during that setup and the original environment is restored afterward, including when initialization raises. The existing behavior for custom trace pipelines without a custom metrics exporter is unchanged.
Impact
Applications can now use
Traceloop.init(metrics_enabled=False)instead of mutating container or process configuration. Existing callers retain the environment-variable behavior because the new argument defaults toNoneand was appended to the public signature.Testing
uv run pytest -q— 424 passeduv run ruff check .uv run mypy traceloop/sdkCloses #1646