chore: bump helm chart version to 4.4.5#3500
Conversation
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🧰 Additional context used📓 Path-based instructions (1)**/*.{js,ts,jsx,tsx,json,md,yaml,yml}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (8)📓 Common learnings📚 Learning: 2025-06-25T13:18:44.103ZApplied to files:
📚 Learning: 2025-06-25T13:20:17.174ZApplied to files:
📚 Learning: 2025-06-25T13:18:04.827ZApplied to files:
📚 Learning: 2025-06-25T14:14:11.965ZApplied to files:
📚 Learning: 2026-04-23T08:44:13.219ZApplied to files:
📚 Learning: 2026-03-25T15:29:25.889ZApplied to files:
📚 Learning: 2026-03-25T15:29:25.889ZApplied to files:
🔇 Additional comments (1)
WalkthroughThe Helm chart metadata in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
🧭 Helm Chart Prerelease PublishedVersion: Install: helm upgrade --install trigger \
oci://ghcr.io/triggerdotdev/charts/trigger \
--version "4.4.5-pr3500.c472761"
|
Reconciles plt-663-chart-fixes with gs-v4.4.4's main-merge (PR #12). Conflicts resolved: - hosting/k8s/helm/Chart.yaml -> hand-merged: bumped prerelease base from 4.4.5 to 4.4.6 to track gs-v4.4.4's version bump (PR triggerdotdev#3500 + triggerdotdev#3501 from upstream). New chart version is now 4.4.6-plt663.1. appVersion v4.4.6 from upstream. - hosting/k8s/helm/Chart.lock -> took gs-v4.4.4's lock (clickhouse 9.4.4 from upstream PR triggerdotdev#3524) then re-ran `helm dependency build`. Auto-merged cleanly: - hosting/k8s/helm/templates/supervisor.yaml (our security-context env wiring + worker pod annotations type fix preserved alongside upstream's extraVolumes/extraVolumeMounts and OTLP fully-qualified URL). Upstream-coverage check (4 PR #13 fixes vs newly-synced upstream main): - _helpers.tpl ($(CLICKHOUSE_PASSWORD) in deploy: true branch) -> NOVEL Upstream's deploy branch still interpolates `.Values.clickhouse.auth.password` literally; our fix is still required when auth.existingSecret is set. - electric.yaml (/app/persistent mount + extraVolumes) -> NOVEL Upstream electric.yaml still renders no volumes/volumeMounts at all. - webapp.yaml (S3 useIam gate + CLICKHOUSE_PASSWORD env) -> NOVEL Upstream webapp.yaml has no useIam reference and no CLICKHOUSE_PASSWORD env var; both are still required. - values.yaml (electric.extraVolumes + s3.external.useIam) -> NOVEL Upstream values.yaml has neither key under electric: nor s3.external:. All 4 fixes remain net-new fork-side patches. No PR #13 commits become redundant from this upstream sync. Smoke tests: - helm dependency build hosting/k8s/helm OK - helm template hosting/k8s/helm OK (renders v4.4.6-plt663.1) Co-authored-by: Cursor <cursoragent@cursor.com>
Follow-up to v4.4.5 release. The
bump-chart-versionjob on the release PR was cancelled before it could run, so Chart.yaml was merged still pointing at 4.4.4. The helm release job (failed run) caught it via its version-match guard.Once this merges I'll re-run the helm release workflow manually.