feat: add OpenRouter detector #4500
Conversation
McPatate
force-pushed
the
feat/add_openrouter_detector
branch
from
f436f10 to
8cee242
Compare
McPatate
force-pushed
the
feat/add_openrouter_detector
branch
from
c192f0c to
8cee242
Compare
|
Hey @shahzadhaider1, lmk if there's anything needed from me to move this PR forward! |
Hey @McPatate, thank you for the contribution. It looks good, but we’re currently pausing the addition of new detectors. We’ll get this merged once we’ve refined our process for maintaining them. |
|
Ok thanks for letting me know! Do you have an idea of the timeline wrt to:
? |
|
Thanks for your patience @McPatate -- we're kicking around ideas for getting this merged in a stable fashion. I should have more for you soon; hopefully today. |
|
OK I've got something of a testing strategy defined; I'm hoping to find the time today or tomorrow (likely tomorrow) to set that up and run this through. Will keep you updated. EDIT: I should say this involves running tons of specific data through this thing, so it's not the kind of test we can reasonably ask contributors to do, at least not yet. |
camgunz
left a comment
camgunz
left a comment
There was a problem hiding this comment.
OK this looks good! Again thanks for your patience.
* refactor: remove unnecessary `AnalysisInfo` field
shahzadhaider1
left a comment
shahzadhaider1
left a comment
There was a problem hiding this comment.
Looks good. Thank you for the great work. We really appreciate it.
|
Happy to contribute 😄 |
3 participants
closes #4499
Description:
Adds the OpenRouter detector as discussed in #4499.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note: I ran
make lintand I'm seeing quite the list of warnings, although none related to the changes I made afaict. Is this safe to ignore?