Skip to content

Conversation

@jordanTunstill
Copy link
Contributor

@jordanTunstill jordanTunstill commented Nov 5, 2025

Problem

When scanning Jira attachments, .msg and .doc were incorrectly identified as archives by archives.Identify(), causing extraction errors during scanning.

Root Cause

The handler flow:
Detects MIME type (.msg → application/vnd.ms-outlook, .doc → application/msword
Calls archives.Identify() to check if file is an archive
If identified as an archive, attempts extraction → errors
These files aren't archives but were being treated as such.

Solution

Added skip logic to prevent archive detection for these file types:
MIME type skip: Added application/vnd.ms-outlook and application/msword to skipArchiverMimeTypes to bypass archive detection for .msg and .doc files

Impact

Prevents previously experienced errors when scanning Jira issues with .msg or attachments
Files are handled by the default handler instead of the archive handler
Minimal impact, as this only adds skip logic for these specific file types

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@jordanTunstill jordanTunstill requested a review from a team November 5, 2025 16:59
@jordanTunstill jordanTunstill requested review from a team as code owners November 5, 2025 16:59
@dustin-decker dustin-decker merged commit fca9545 into main Nov 6, 2025
13 checks passed
@dustin-decker dustin-decker deleted the CSM-1557 branch November 6, 2025 16:20
@jordanTunstill jordanTunstill changed the title Added .msg and .doc to skipArchiverMimeTypes, in line with THOG fix Added .msg and .doc to skipArchiverMimeTypes Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants