[pull] master from php:master#1016
Merged
Merged
Conversation
When the value of the parameter of openlog() contains NUL byte(s), throw a ValueError instead of silently truncates it.
) Locale::lookup() and locale_lookup() should not return the fallback locale when canonicalizing a language tag fails. Returning the fallback hid the intl error raised by lookup_loc_range() for invalid language tags. Return NULL in that error case instead, while preserving the exception path when intl.use_exceptions is enabled. Closes #22306
* PHP-8.4: ext/intl: Fix Locale::lookup() fallback on invalid language tags (#22306)
* PHP-8.5: ext/intl: Fix Locale::lookup() fallback on invalid language tags (#22306)
PHP 8.5 prefixes intl error messages with the calling function name. Update the regression test expectations to match the branch behavior for Locale::lookup() and locale_lookup().
* PHP-8.5: ext/intl: Fix Locale::lookup() test expectations (#22306)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )