[pull] master from php:master#1063
Merged
Merged
Conversation
* PHP-8.4: ext/soap: backport GH-22586 fix.
* PHP-8.5: ext/soap: backport GH-22586 fix.
…s lookup (#22593) lc_length was set to name_length + 1, one past the actual lowercased string length, so zend_hash_str_find_ptr() (which expects a strlen-style length) never matched an existing class entry. This made class lookups during phpdbg's signal-handler interruption path always fail silently. Replaced the manual emalloc/tolower/efree dance with zend_hash_str_find_ptr_lc(), which performs the lowercase copy and lookup in one call and removes the surface for this class of bug.
* PHP-8.4: phpdbg: Fix off-by-one in phpdbg_safe_class_lookup() signal-safe class lookup (#22593)
* PHP-8.5: phpdbg: Fix off-by-one in phpdbg_safe_class_lookup() signal-safe class lookup (#22593)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )