Add lambda-otel4s module by alexcardell · Pull Request #459 · typelevel/feral

alexcardell · 2024-02-23T17:19:10Z

Supercedes #456

Adds lambda-natchez module
Adds lambda-otel4s module
- Traces lambdas with semantic conventions applied
Adds otel4s examples
Add scalafix migration to port natchez package imports -- (removes previous version scalafix migrations)

This is targeting otel4s 0.16.x ~~0.15.x~~ ~~0.14.x~~ ~~0.13.x~~ ~~0.12.x~~ ~~0.11.x~~ ~~0.10.x~~ ~~0.9.x~~ ~~0.8.x~~ ~~0.7.x~~ ~~0.6.x~~ ~~0.5.x~~

Links

https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/
https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/

alexcardell · 2024-02-27T18:59:29Z

Currently pointed at a local snapshot so CI will definitely fail, as otel4s main has NoPublish for everything involving the SDK

alexcardell · 2024-04-19T17:37:34Z

@iRevive Updated all the attributes and removed semconv-experimental

Would appreciate another look when you have time

iRevive · 2024-04-20T07:10:03Z

@alexcardell the changes look good.

We still need to wait for a release of https://github.com/http4s/http4s-otel4s-middleware, right?

alexcardell · 2024-04-22T08:49:10Z

The middleware would be useful for the example, but I don't believe it's necessary otherwise

alexcardell · 2024-05-08T20:25:10Z

Upgraded to otel4s 0.7 but thanks to sbt 1.10 that required a few other updates

Also added http4s-otel4s-middleware to the example

iRevive · 2024-05-10T08:37:27Z

+  .jvmSettings(libraryDependencies ++= Seq(
+    "org.typelevel" %%% "otel4s-oteljava-trace-testkit" % otel4sVersion % Test
+  ))


We can use otel4s-sdk-trace-testkit to run tests across all platforms. Here is an example: alexcardell#2

armanbilge · 2024-09-13T07:47:59Z

I'd like to merge this for an upcoming release! @alexcardell do you have more time to work on it? @iRevive any changes in otel4s since this PR was opened that we should account for? Thanks both for your work on this, sorry it took me so long to circle back 🙏

iRevive · 2024-09-13T07:59:31Z

@armanbilge I believe bumping otel4s version from 0.7.0 to 0.9.0 should be smooth.

One suggestion regarding this PR: we can switch to otel4s-sdk-trace-testkit to run tests across all platforms.

alexcardell · 2024-09-15T21:33:38Z

@armanbilge I will fix it up!

alexcardell · 2024-09-15T21:35:40Z

@iRevive thanks for the PR to my branch, sorry I did not notice that for many moons

alexcardell · 2024-09-15T22:53:39Z

Added JS tests for the otel4s module -- they can't be in shared because of the different platform Contexts, without a fair bit of work

otel4s 0.8 looks like it works fine, however I can't update to 0.9 yet until http4s/http4s-otel4s-middleware#123 is in, as it's used in the examples module

iRevive · 2024-09-16T07:26:21Z

One more minor improvement: alexcardell#3.
We can use otel4s-semconv-experimental in tests to ensure our attributes match the specification.

iRevive · 2024-09-16T07:26:46Z

+/**
+ * Temporary aliases for Lambda message-specific attributes in otel4s-semconv-experimental
+ */
+object LambdaMessageAttributes {


Should attributes be package private?

I think this was a shim for otel4s-semconv-experimental anyway, back when I thought this would merge before that was available, I can probably replace this

lambda-otel4s still cannot depend on the otel4s-semconv-experimental, because semconv-experimental may receive binary breaking updates. And this will affect feral compatibility.

So far, I came up with the following strategy:

Redefine required attributes in the library (like you did), ideally in a private package

Use otel4s-semconv-experimental in tests to ensure your attributes match the specification (even the experimental one).

Once attributes get promoted to the otel4s-semconv stable artifact - replace handcrafted attributes with the stable one

Added some specific attribute tests, a little bit boilerplatey but did catch a small issue

iRevive · 2024-09-16T07:27:20Z

+protected trait EventSpanAttributes[E] {
+  def contextCarrier(e: E): Map[String, String]
+  def spanKind: SpanKind
+  def attributes(e: E): List[Attribute[_]]


As an alternative, we can use Attributes collection there instead.

iRevive · 2024-09-16T09:50:23Z

I am not entirely clear how aws-otel Lambda layers will play with this, and whether that's in scope

This one is complicated. If I get it right, it's only a predefined (preinstalled) otel-compatible collector. Hence, it should work with otel4s-sdk and otel4s-oteljava out of the box.

Apart from the distro, there is a 'otel lambda layer': https://github.com/open-telemetry/opentelemetry-lambda.
Each language layer has a handcrafted entry point. The Java layer, for example, won't work with otel4-sdk but should work with otel4s-oteljava.

alexcardell · 2024-09-16T14:45:12Z

Good to go when I can bump to otel4s 0.9, but given the middleware is only used in the examples, perhaps we can just indicate where you would wrap the client with the middleware, rather than adding that dependency

iRevive · 2024-09-16T14:53:10Z

There are also some AWS goodies in the upcoming 0.10.0 otel4s release (for otel4s-sdk): https://typelevel.org/otel4s/sdk/aws-xray-propagator.html#aws-lambda.

It depends on how urgently we need to release a new version of feral, but I'm fine with keeping examples out of the scope to unblock the release.

armanbilge · 2024-09-16T15:15:49Z

It depends on how urgently we need to release a new version of feral

I don't have an urgency, I had neglected this PR so wanted to make sure that we can land it soon :) thanks both for refreshing things!

alexcardell · 2024-09-16T18:37:14Z

Fixed the 0.9 issues, good to go

alexcardell · 2026-04-08T09:29:18Z

bumped

apologies for the force push, rebasing was a pain

iRevive · 2026-04-15T20:12:40Z

+
+object TracedHandler {
+
+  def apply[F[_]: Monad: Tracer, Event, Result](


We should eventually add an overload that takes TracerProvider, e.g.:

def apply[F[_]: Monad: TracerProvider, Event, Result](...): F[Option[Result]] = TracerProvider[F] .tracer("feral.lambda").withVersion(BuildInfo.version).get .flatMap { implicit T: Tracer[F] => ... // rest of the code }

I am happy to swap it over if that's the preferred dependency, I think at the time I wrote this some libraries were accepting Tracer

I know we have some apps that set both up implicitly for that reason, and an overload may cause a problem unless specifically named

iRevive · 2026-04-15T20:13:02Z

@armanbilge looks good to me, would you mind taking a look too?

sources: https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/ https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/#sqs

This was referenced Feb 23, 2024

Extract lambda-natchez module #456

Closed

Integrate feral-lambda with otel4s #340

Open

alexcardell force-pushed the lambda-otel4s branch from 6b6999d to 4242256 Compare February 27, 2024 18:32

alexcardell marked this pull request as ready for review March 12, 2024 19:21

alexcardell changed the title ~~WIP: Add lambda-otel4s module~~ Add lambda-otel4s module Mar 12, 2024

iRevive reviewed Mar 31, 2024

View reviewed changes

Comment thread lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/FaasAttributes.scala Outdated

iRevive reviewed Mar 31, 2024

View reviewed changes

Comment thread lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/TracedHandler.scala Outdated

iRevive reviewed Mar 31, 2024

View reviewed changes

Comment thread lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/package.scala Outdated

alexcardell force-pushed the lambda-otel4s branch 2 times, most recently from 84ee6f9 to 96ce0a9 Compare May 8, 2024 09:39

iRevive reviewed May 10, 2024

View reviewed changes

iRevive reviewed Sep 16, 2024

View reviewed changes

iRevive approved these changes Sep 16, 2024

View reviewed changes

alexcardell added 22 commits April 7, 2026 15:16

Fix 0.9 bump

691f832

Move KernelSources to KernelSource companion

d08a948

Remove Event parameter from TracedHandler

5dc42c1

Use shared trace handler suite

86ae33e

Add v0.4.0 rewrites for natchez module

2b398e8

Fix formatting

fcd9a67

Add scalafix v0.4.0 rewrite input/output

fc41dcb

Split 0.3.0 and 0.4.0 rewrite rules into subprojects

926baa0

Update workflows

6ef9c20

Fix scalafix 0.4.0 rewrites test

ceae158

Remove 0.3.0 migrations

dae7207

Remove unused examples imports

66a3d93

Rename EventSpanAttributes -> EventAttributeSources

c16c20a

Add http4s-otel4s-middleware

5cb414e

Simplify otel attributes file structure

ffc962e

Fix imports

edee180

Update example

5e628d7

Fix munit-cats-effect dependency reference

e23b16f

Fix fixture

7abe21e

fix deprecation

e68bfeb

Update mergify

432cc4b

Bump

42278bf

alexcardell force-pushed the lambda-otel4s branch from f3d5c74 to 42278bf Compare April 7, 2026 15:31

alexcardell added 2 commits April 8, 2026 09:50

fmt

4a18338

Fix lambda plugin scala version

b5c6efc

Add comment explaining semanticdb

5eacd1b

iRevive reviewed Apr 15, 2026

View reviewed changes

more semantic conventions

e62dee3

sources: https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/ https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/#sqs


		object TracedHandler {

		def apply[F[_]: Monad: Tracer, Event, Result](

Uh oh!

Conversation

alexcardell commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Links

Uh oh!

alexcardell commented Feb 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexcardell commented Apr 19, 2024

Uh oh!

iRevive commented Apr 20, 2024

Uh oh!

alexcardell commented Apr 22, 2024

Uh oh!

alexcardell commented May 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armanbilge commented Sep 13, 2024

Uh oh!

iRevive commented Sep 13, 2024

Uh oh!

alexcardell commented Sep 15, 2024

Uh oh!

alexcardell commented Sep 15, 2024

Uh oh!

alexcardell commented Sep 15, 2024

Uh oh!

iRevive commented Sep 16, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iRevive commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcardell commented Sep 16, 2024

Uh oh!

iRevive commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armanbilge commented Sep 16, 2024

Uh oh!

alexcardell commented Sep 16, 2024

Uh oh!

alexcardell commented Apr 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iRevive commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexcardell commented Feb 23, 2024 •

edited

Loading

iRevive commented Sep 16, 2024 •

edited

Loading

iRevive commented Sep 16, 2024 •

edited

Loading