Configurable retry params #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduces two new extension parameters: - `TYPESENSE_CONNECTION_TIMEOUT_SECONDS` - `TYPESENSE_RETRY_INTERVAL_SECONDS` - updates `config.js` to parse values from environment variables - replaces random timeout values with user-defined config in `createTypesenseClient.js` - improves predictability and customizability of Typesense client behavior
tharropoulos
force-pushed
the
configurable-retry-params
branch
from
e777717 to
ff154ac
Compare
- reintroduce random fallback values for connection and retry intervals when environment variables are missing or invalid - modify `createTypesenseClient` to reuse fallback logic - add test suite to verify default and random behavior for client config - extend test script to include `typesenseClientDefaults.spec.js`
tharropoulos
force-pushed
the
configurable-retry-params
branch
from
ff154ac to
ac1e128
Compare
jasonbosco
requested changes
Aug 1, 2025
extension.yaml
Outdated
| The timeout in seconds for connections to Typesense. This applies to both connection timeout. | ||
| type: string | ||
| example: "60" | ||
| default: "60" |
Member
There was a problem hiding this comment.
@tharropoulos The default in the UI is still set to 60, which will prevent the jitter from applying by default.
extension.yaml
Outdated
| The retry interval in seconds for connections to Typesense. This applies to both connection timeout. | ||
| type: string | ||
| example: "60" | ||
| default: "60" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add the ability to reconfigure retry parameters from a random integer between 60 and 120 seconds respectively to an arbitrary value.
PR Checklist