Fix two emoji#167
Closed
MDLC01 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I think both are valid. https://www.unicode.org/Public/17.0.0/ucd/emoji/emoji-data.txt contains # and *, both in the basic Emoji category, and further down as an Emoji_Component. As further evidence, here's a screenshot of a font rendering # and * with text presentation, emoji presentation, and emoji presentation + combining keycap So I think these should be new variants, perhaps |
Collaborator
Author
|
So I did a bit of research, and I think there is no exhaustive list of emoji. Meaning the absence of bare * and # from some data files indeed does not indicate that they aren't emoji. I will close this PR and left some additional comments at #166 (comment) and typst/typst#8282 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two emoji are missing a combining enclosing keycap component. With this fix, all emoji in
emojishould be part of https://www.unicode.org/Public/17.0.0/emoji/emoji-test.txt, and more specifically https://unicode.org/emoji/charts/emoji-ordering.txt, which seems to only include fully-qualified forms and components.Related: #166.