fix(orchestrator): add Validated state transition and log in mergeconflictsignal#377
Open
kevinlnew wants to merge 1 commit into
Open
fix(orchestrator): add Validated state transition and log in mergeconflictsignal#377kevinlnew wants to merge 1 commit into
kevinlnew wants to merge 1 commit into
Conversation
…flictsignal The mergeconflictsignal controller was publishing directly to the batch topic on success without transitioning the request to Validated or recording a log entry. This adds the missing CAS Started→Validated state transition and publishes a RequestStatusValidated log entry before forwarding to batch.
kevinlnew
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validatedor recording a log entry.Started → Validatedstate transition and publishes aRequestStatusValidatedlog entry before forwarding to batch.Test plan
bazel test //submitqueue/orchestrator/controller/mergeconflictsignal/...— all passbazel test //submitqueue/entity/...— all passbazel test //submitqueue/orchestrator/controller/dlq/...— all pass (DLQ handler unchanged)make fmt/make lintclean