refactor(controller): route metrics through observability/metrics Emitter#183
Open
xytan0056 wants to merge 1 commit into
Open
refactor(controller): route metrics through observability/metrics Emitter#183xytan0056 wants to merge 1 commit into
xytan0056 wants to merge 1 commit into
Conversation
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
f3b33a1 to
381f8df
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
fc409c7 to
92ec6d7
Compare
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
381f8df to
ab10f3b
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
92ec6d7 to
0c4fa79
Compare
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
ab10f3b to
76e7a51
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
0c4fa79 to
4e0dd99
Compare
xytan0056
commented
Jul 11, 2026
| if err != nil { | ||
| result = ResultFail | ||
| } | ||
| // TODO: when err != nil, derive failure_type and failure_source tags from |
Contributor
Author
There was a problem hiding this comment.
update when errors package is ready
xytan0056
changed the title
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
76e7a51 to
a101bd7
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
4e0dd99 to
2d79c40
Compare
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
a101bd7 to
1ecc59c
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
2d79c40 to
f8d2cad
Compare
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
1ecc59c to
a101bd7
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
f8d2cad to
2d79c40
Compare
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
a101bd7 to
d968dab
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
2d79c40 to
e2135eb
Compare
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
d968dab to
e21b75c
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
e2135eb to
cd577d8
Compare
xytan0056
force-pushed
the
pr3-recordrequest
branch
from
cd577d8 to
6f3e10c
Compare
xytan0056
force-pushed
the
pr2-trackinflight
branch
from
e21b75c to
67218e4
Compare
xytan0056
changed the title
xytan0056
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tally.Scopewith*metrics.Emitterin controllerParamsand all handler/helper signaturescontroller/metrics.gowithrequestMetricsstruct andemitterFormemoization (per the design doc pattern)Timer(x).Record(d)→DurationHistogram(op, x, buckets).RecordDuration(d)with explicit per-callsite bucketsemitFailureMetricnow takes*metrics.Emitter+opinstead oftally.Scopecompare_target_graphsflattens from nested subscope to top-level opDepends on #181.
Test plan
make build/make test/make gazellepassmetrics.Nop()instead oftally.NoopScope