Replace Chinese comment with English in nullcontext method#1655
Closed
daviddl9 wants to merge 1 commit intounclecode:mainfrom
Closed
Replace Chinese comment with English in nullcontext method#1655daviddl9 wants to merge 1 commit intounclecode:mainfrom
daviddl9 wants to merge 1 commit intounclecode:mainfrom
Conversation
The docstring "异步空上下文管理器" has been replaced with "Async null context manager that yields nothing." in both the source file and the documentation.
Owner
|
Thanks for the suggestion, @daviddl9! We're keeping this one as-is — it's a small memento from one of our early contributors. Closing, but appreciate you thinking about code consistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
异步空上下文管理器with EnglishAsync null context manager that yields nothing.crawl4ai/async_webcrawler.py) and the documentation (deploy/docker/c4ai-code-context.md)Details
The
nullcontextmethod inAsyncWebCrawlerhad a Chinese comment that should be in English for consistency with the rest of the codebase.Test plan