split: accept overflow in --number option like GNU#10520
Open
naoNao89 wants to merge 1 commit intouutils:mainfrom
Open
split: accept overflow in --number option like GNU#10520naoNao89 wants to merge 1 commit intouutils:mainfrom
naoNao89 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
fix-split-overflow-10389
branch
from
64ae96e to
e31d74f
Compare
|
GNU testsuite comparison: |
Collaborator
|
I think we have to pull the upstream changes to the split utility, its changed to match this behavior |
Collaborator
|
Actually I think the issue that this is fixing is incorrect, I am unable to replicate this on upstream |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
fix-split-overflow-10389
branch
3 times, most recently
from
8fdf58d to
a8ed2f8
Compare
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
fix-split-overflow-10389
branch
2 times, most recently
from
4485b6f to
0176ecb
Compare
|
GNU testsuite comparison: |
Use parse_size_u64_max to accept overflow values and clamp them to u64::MAX. Add MAX_FILES_CAP (100) to prevent hangs when creating output files. Add MAX_BYTE_CHUNKS, MAX_LINE_CHUNKS, MAX_RR_CHUNKS constants to limit chunks processed for each split mode.
naoNao89
force-pushed
the
fix-split-overflow-10389
branch
from
0176ecb to
91cc2da
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10389
where split rejected overflow values like 2^64. Now it matches GNU behavior by clamping to
u64::MAXinstead of erroring. Switched from parse_size_u64() to parse_size_u64_max() based on GNU's OVERFLOW_OK pattern. Added regression test to prevent future breakage.