expr: fix regex matching on inputs containing newlines#10543
Merged
cakebaker merged 2 commits intouutils:mainfrom Jan 30, 2026
Merged
expr: fix regex matching on inputs containing newlines#10543cakebaker merged 2 commits intouutils:mainfrom
cakebaker merged 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
the ci isn't happy |
Collaborator
Author
|
It's all flakiness :( |
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was investigating the onig flags to see what is missing with the multiline related options to achieve gnu compatibility and I found that there was a
RegexOptions::REGEX_OPTION_MULTILINEand when testing adding it to all of the places where the regex options singleline was added it matched the missing multiline regexes that were previously failingFixes: #10542