Skip to content

sort: defer compress program errors until needed - #13656

Open
wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:sort-compress-error-priority
Open

sort: defer compress program errors until needed#13656
wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:sort-compress-error-priority

Conversation

@wtcpython

Copy link
Copy Markdown
Contributor

Fixes #13148.

Defer reporting compression program errors until external sorting is required, allowing earlier input errors to be reported without an unrelated compression warning.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/mb-non-utf8 is no longer failing!
Congrats! The gnu test tests/mv/mv-exchange is no longer failing!
Congrats! The gnu test tests/od/od-j is no longer failing!
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Congrats! The gnu test tests/dd/no-allocate is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@wtcpython
wtcpython force-pushed the sort-compress-error-priority branch from d468737 to 8ab9b62 Compare August 5, 2026 09:35
@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 18.31%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 346 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_with_path 571.4 µs 699.5 µs -18.31%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wtcpython:sort-compress-error-priority (8ab9b62) with main (21d4e96)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minorbug(sort): priotize the compress program over files

1 participant