find: warn about useless -name/-wholename patterns - #812
Open
Xylphy wants to merge 1 commit into
Open
Conversation
Emit non-fatal warnings at parse time for patterns that can never match,
matching GNU findutils behavior:
- Warn if a -name/-iname pattern contains a directory separator ('/'),
since these predicates match against basenames only.
- Warn if a -path/-wholename/-ipath/-iwholename pattern ends with '/',
since find never constructs paths with a trailing separator.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
+ Coverage 91.93% 91.97% +0.04%
==========================================
Files 35 35
Lines 7251 7275 +24
Branches 378 381 +3
==========================================
+ Hits 6666 6691 +25
+ Misses 443 440 -3
- Partials 142 144 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 17.42%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
|
|
Commit b757e1f has test result changes: bfs testsuite: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783
Summary
This PR implements GNU-compatible warnings for
findpatterns that can never match anything, addressing issue #783.Previously, uutils
findsilently accepted patterns like-name /a.txtor-wholename foo/, which will never produce matches. GNUfindemits non-fatal warnings to help users catch these common mistakes early.