feat(isDate): add delimiter-less date formats#2659
Open
xseman wants to merge 5 commits intovalidatorjs:masterfrom
Open
feat(isDate): add delimiter-less date formats#2659xseman wants to merge 5 commits intovalidatorjs:masterfrom
xseman wants to merge 5 commits intovalidatorjs:masterfrom
Conversation
Add test cases for `isDate` validator to handle various delimiter-less date formats including `YYYYMMDD`, `YYMMDD`, `MMDDYYYY`, and `DDMMYYYY`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2572 2601 +29
Branches 651 655 +4
=========================================
+ Hits 2572 2601 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
The |
Member
|
Thanks for opening this PR! I think we should only accept these behind a non-default option, to not cause a breaking change |
Author
|
Thanks for the feedback, @WikiRik. What do you think about adding an opt-in for delimiter-less format support to avoid breaking changes? const default_date_options = {
format: 'YYYY/MM/DD',
delimiters: ['/', '-'],
strictMode: false,
allowDelimiterless: false, // <----
};// Existing behavior unchanged
validator.isDate('20020715'); // false
// Opt-in to new feature
validator.isDate('20020715', {
format: 'YYYYMMDD',
allowDelimiterless: true
}); // true |
Member
|
@xseman yup, that's exactly what I had in mind! |
Author
|
Thanks for the quick feedback, last changes should do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test cases for
isDatevalidator to handle various delimiter-less date formats includingYYYYMMDD,YYMMDD,.MMDDYYYYandDDMMYYYYChecklist