-
Notifications
You must be signed in to change notification settings - Fork 398
vcc_acl: Add +fold(-report) sub-flag omit +fold warnings #4354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
985258f to
ee1c7b9
Compare
|
bugwash with @bsdphk : So I have adjusted the docs but also the rest of the PR, just because it's easy enough. |
|
I have updated the patch to the last suggestion with the sub-flag in parenthesis, but I stuck with From the docs:
|
| } else if (vcc_IdIs(tl->t, "fold")) { | ||
| acl->flag_fold = sign; | ||
| vcc_NextToken(tl); | ||
| vcc_parseAclFold(tl, sign); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stop the loop if we failed in vcc_parseAclFold, otherwise we might get double error reporting. Maybe we can turn the loop into a while (!tl->error) ?
to reduce nesting in the next commit
With a lot of folding going on, the warnings can easily bury more relevant CLI output.
With a lot of folding going on, the warnings can easily bury more relevant CLI output.