Skip to content

feat: kysely#509

Closed
phonzammi wants to merge 4 commits intomainfrom
phonzammi/dev
Closed

feat: kysely#509
phonzammi wants to merge 4 commits intomainfrom
phonzammi/dev

Conversation

@phonzammi
Copy link
Copy Markdown
Member

@phonzammi phonzammi commented Apr 13, 2025

@magne4000

Let me try to integrate kysely into Bati. Please help me resolve this feature.
I have 2 questions :

  1. The docs mention that Kysely also runs in the browser, but I don't think that's a good idea in most cases. Should we add a new ERROR_KYSELY_R_SERVER rule?
  2. Should we add integration with the D1 Database? They don’t have an official dialect for D1 — only a community/third-party one (https://github.com/aidenwallis/kysely-d1), and I saw it hasn’t been updated in a year.

@phonzammi phonzammi changed the title feat: new-boilerplate kysely feat: kysely Apr 13, 2025
@magne4000
Copy link
Copy Markdown
Member

1. The docs mention that [Kysely also runs in the browser](https://kysely.dev/docs/runtimes/browser), but I don't think that's a good idea in most cases. Should we add a new `ERROR_KYSELY_R_SERVER` rule?

I'm not sure to understand. What would the error be about?

2. Should we add integration with the D1 Database? They don’t have an official dialect for D1 — only a community/third-party one (https://github.com/aidenwallis/kysely-d1), and I saw it hasn’t been updated in a year.

Perhaps we can use the SQLite integration instead when using D1?

@phonzammi
Copy link
Copy Markdown
Member Author

phonzammi commented Apr 21, 2025

I'm not sure to understand. What would the error be about?

I mean, we require users to use a server when they choose kysely, so I'm not sure what the ideal boilerplate setup would look like without a server.

Yeah, they can still fetch todos from the database, but what about adding new ones?

@magne4000
Copy link
Copy Markdown
Member

I'm not sure to understand. What would the error be about?

I mean, we require users to use a server when they choose kysely, so I'm not sure what the ideal boilerplate setup would look like without a server.

We should just treat Kysely as the others, it doesn't really mean anything to run kysely client side for Bati's use case

@phonzammi
Copy link
Copy Markdown
Member Author

We should just treat Kysely as the others, it doesn't really mean anything to run kysely client side for Bati's use case

Well, after comparing it to the SQLite boilerplate without a server, I think it's fine if we don't add the ERROR_KYSELY_R_SERVER rule.

@magne4000
Copy link
Copy Markdown
Member

@phonzammi what is the status on this PR?

@phonzammi
Copy link
Copy Markdown
Member Author

phonzammi commented Jun 2, 2025

2. Should we add integration with the D1 Database? They don’t have an official dialect for D1 — only a community/third-party one (https://github.com/aidenwallis/kysely-d1), and I saw it hasn’t been updated in a year.

Perhaps we can use the SQLite integration instead when using D1?

I'm unsure how to do it

@phonzammi
Copy link
Copy Markdown
Member Author

Superseded by #643

@phonzammi phonzammi closed this Dec 24, 2025
@magne4000 magne4000 deleted the phonzammi/dev branch December 24, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants