initial language server protocol implementation by prabirshrestha · Pull Request #27 · vim-jp/go-vimlparser

prabirshrestha · 2017-01-08T06:34:39Z

Here is the initial implementation of some of the features of language server protocol (#26)
Currently it only supports 3 method - initialize, textDocument/didOpen, textDocument/documentSymbols as a proof of concept.
This vim plugin is not included in this CR (but if any one wants to try it out let me know and I can share it)

The implementation is similar to https://github.com/sourcegraph/go-langserver

My next step would be to add support for more of the lsp features and also write a vscode plugin so that I can test with a real client.

Note: I'm not a go dev so this may not be idiomatic go code but feel free to comment.

review-dog · 2017-01-08T06:35:55Z

langserver/handle_text_document_symbol.go

+		} else {
+			return getDocumentSymbols(params, node), nil
+		}
+		return nil, nil


[govet] _{reported by reviewdog 🐶}
unreachable code

review-dog · 2017-01-08T06:35:56Z

langserver/handle_text_document_symbol.go

+		}
+		return nil, nil
+	} else {
+		return nil, errors.New(fmt.Sprintf("% not open", params.TextDocument.URI))


[govet] _{reported by reviewdog 🐶}
unrecognized printf verb 'n'

review-dog · 2017-01-08T06:35:56Z

langserver/lsp.go

+	ProcessID             int                `json:"processId,omitempty"`
+	RootPath              string             `json:"rootPath,omitempty"`
+	InitializationOptions InitializeOptions  `json:"initializationOptions,omitempty"`
+	Capabilities          ClientCapabilities `json:"capabilities",omitempty`


[govet] _{reported by reviewdog 🐶}
struct field tag json:"capabilities",omitempty not compatible with reflect.StructTag.Get: bad syntax for struct tag pair

review-dog · 2017-01-08T06:35:58Z

langserver/handle_text_document_did_open.go

+	f, err := NewVimFile(params.TextDocument)
+	if err != nil {
+		return nil, err
+	} else {


[golint] _{reported by reviewdog 🐶}
if block ends with a return statement, so drop this else and outdent its block

review-dog · 2017-01-08T06:35:58Z

langserver/handle_text_document_symbol.go

+		node, err := f.GetAst()
+		if err != nil {
+			return nil, err
+		} else {


[golint] _{reported by reviewdog 🐶}
if block ends with a return statement, so drop this else and outdent its block

review-dog · 2017-01-08T06:35:58Z

langserver/handle_text_document_symbol.go

+			return getDocumentSymbols(params, node), nil
+		}
+		return nil, nil
+	} else {


[golint] _{reported by reviewdog 🐶}
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)

review-dog · 2017-01-08T06:35:58Z

langserver/handle_text_document_symbol.go

+		}
+		return nil, nil
+	} else {
+		return nil, errors.New(fmt.Sprintf("% not open", params.TextDocument.URI))


[golint] _{reported by reviewdog 🐶}
should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...)

review-dog · 2017-01-08T06:35:58Z

langserver/handler.go

+	"github.com/sourcegraph/jsonrpc2"
+)
+
+func NewHandler() jsonrpc2.Handler {


[golint] _{reported by reviewdog 🐶}
exported function NewHandler should have comment or be unexported

review-dog · 2017-01-08T06:35:59Z

langserver/lsp.go

+type SymbolKind int
+
+const (
+	SKFile        SymbolKind = 1


[golint] _{reported by reviewdog 🐶}
exported const SKFile should have comment (or a comment on this block) or be unexported

review-dog · 2017-01-08T06:35:59Z

langserver/lsp.go

+	SKArray       SymbolKind = 18
+)
+
+type SymbolInformation struct {


[golint] _{reported by reviewdog 🐶}
exported type SymbolInformation should have comment or be unexported

review-dog · 2017-01-08T06:35:59Z

langserver/lsp.go

+	Location Location   `json:"location"`
+}
+
+type Location struct {


[golint] _{reported by reviewdog 🐶}
exported type Location should have comment or be unexported

review-dog · 2017-01-08T06:35:59Z

langserver/lsp.go

+	Range Range  `json:"range"`
+}
+
+type Range struct {


[golint] _{reported by reviewdog 🐶}
exported type Range should have comment or be unexported

review-dog · 2017-01-08T06:35:59Z

langserver/lsp.go

+	End   Position `json:"end"`
+}
+
+type Position struct {


[golint] _{reported by reviewdog 🐶}
exported type Position should have comment or be unexported

coveralls · 2017-01-08T06:39:16Z

Coverage decreased (-2.4%) to 80.917% when pulling d320a46 on prabirshrestha:langserver-vim into f57a807 on haya14busa:master.

coveralls · 2017-01-08T06:39:16Z

Coverage decreased (-2.4%) to 80.917% when pulling d320a46 on prabirshrestha:langserver-vim into f57a807 on haya14busa:master.

haya14busa · 2017-01-08T07:23:10Z

Thanks @prabirshrestha ! It looks interesting. I will check it later soon.

review-dog · 2017-01-08T18:22:10Z

langserver/handle_text_document_symbol.go

+		}
+		return getDocumentSymbols(params, node), nil
+	}
+	return nil, fmt.Errorf("% not open", params.TextDocument.URI)


[govet] _{reported by reviewdog 🐶}
unrecognized printf verb 'n'

review-dog · 2017-01-08T18:22:12Z

langserver/lsp.go

+	Trace                 string             `json:"trace,omitempty"`
+}
+
+type InitializeOptions struct {


[golint] _{reported by reviewdog 🐶}
exported type InitializeOptions should have comment or be unexported

coveralls · 2017-01-08T18:23:53Z

Coverage decreased (-2.4%) to 81.005% when pulling 3351ff2 on prabirshrestha:langserver-vim into f57a807 on haya14busa:master.

coveralls · 2017-01-08T18:23:53Z

Coverage decreased (-2.4%) to 81.005% when pulling 3351ff2 on prabirshrestha:langserver-vim into f57a807 on haya14busa:master.

review-dog · 2017-01-08T18:26:44Z

langserver/lsp.go

+	Trace                 string             `json:"trace,omitempty"`
+}
+
+type InitializeOptions struct {


[golint] _{reported by reviewdog 🐶}
exported type InitializeOptions should have comment or be unexported

coveralls · 2017-01-08T18:28:16Z

Coverage decreased (-2.4%) to 81.005% when pulling 2fc51de on prabirshrestha:langserver-vim into f57a807 on haya14busa:master.

coveralls · 2017-01-08T18:28:16Z

Coverage decreased (-2.4%) to 81.005% when pulling 2fc51de on prabirshrestha:langserver-vim into f57a807 on haya14busa:master.

support lambda

natebosch · 2018-01-17T04:36:49Z

Is there any chance of this getting revived? It would be awesome to have a language server for viml!

prabirshrestha · 2018-01-20T19:30:26Z

@natebosch I believe @haya14busa is still waiting on me to fix lint issues. I haven't been able to have a look at this yet but if you are interested I would be more than happy to give you write access to my repo so that the issues can be addressed first.

mattn · 2019-01-14T14:56:24Z

Any update on this?

prabirshrestha · 2019-01-15T12:14:27Z

No updates from my side. Bit more details at here. #26

I do write vimscript a lot so if someone is willing to take this further I would be glad to help out.

mattn · 2019-01-22T06:06:02Z

I implemented completion for v: constants.

@haya14busa If you don't have enough time to do this, I can add some features to integrate to Vim script.

mattn · 2019-02-05T10:53:50Z

@prabirshrestha I created efm-langserver that is based on your langserver and haya14busa's errorformat. Thanks.

https://github.com/mattn/efm-langserver

prabirshrestha · 2019-05-19T06:46:54Z

Haven't tried it but this does seem promising. https://github.com/iamcco/vim-language-server

initial language server protocol implementation

d320a46

review-dog reviewed Jan 8, 2017

View reviewed changes

fix some golint issues

3351ff2

review-dog reviewed Jan 8, 2017

View reviewed changes

fixed go vet issues

2fc51de

review-dog reviewed Jan 8, 2017

View reviewed changes

prabirshrestha mentioned this pull request Feb 6, 2017

get an AST of a viml source neovim/neovim#6058

Closed

haya14busa pushed a commit that referenced this pull request Nov 17, 2017

Merge pull request #27 from haya14busa/vim-vimlparser-lambda

b5f8373

support lambda

prabirshrestha mentioned this pull request Jan 13, 2019

make contentChanges smaller in DidChangeTextDocumentParams prabirshrestha/vim-lsp#241

Merged

Conversation

prabirshrestha commented Jan 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 8, 2017

Uh oh!

coveralls commented Jan 8, 2017

Uh oh!

haya14busa commented Jan 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 8, 2017

Uh oh!

coveralls commented Jan 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 8, 2017

Uh oh!

coveralls commented Jan 8, 2017

Uh oh!

natebosch commented Jan 17, 2018

Uh oh!

prabirshrestha commented Jan 20, 2018

Uh oh!

mattn commented Jan 14, 2019

Uh oh!

prabirshrestha commented Jan 15, 2019

Uh oh!

mattn commented Jan 22, 2019

Uh oh!

mattn commented Feb 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prabirshrestha commented May 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

prabirshrestha commented Jan 8, 2017 •

edited

Loading

mattn commented Feb 5, 2019 •

edited

Loading