fix(rolldown): use decimal bytes for file sizes#269
Open
webfansplz wants to merge 1 commit intomainfrom
Open
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DevTools file size formatting to use decimal (1000-based) conversion so the displayed units (kB/MB/GB…) match SI conventions and align with rolldown_plugin_vite_reporter.
Changes:
- Switch
bytesToHumanSizefrom 1024-based to 1000-based scaling and update unit label tokB. - Update unit tests to reflect 1000-based thresholds.
- Adjust
FileSizeBadgethresholds from 1024 to 1000.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/rolldown/src/app/utils/format.ts | Converts byte formatting to decimal (1000) and updates displayed units. |
| packages/rolldown/src/app/utils/tests/format.test.ts | Updates expectations for decimal thresholds and kB unit label. |
| packages/rolldown/src/app/components/display/FileSizeBadge.vue | Aligns size thresholds with decimal kilobytes (1000). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #268
DevTools was using binary (
1024) conversion while labeling sizes asKB/MB. By convention,kB/MBshould be decimal (1000), while binary units should be labeledKiB/MiB.This change switches DevTools to decimal-based size formatting, and also align with the rolldown_plugin_vite_reporter.