Skip to content

feat(vitest): support vi.waitFor method#4113

Merged
sheremet-va merged 18 commits intovitest-dev:mainfrom
Dunqing:feat/wait-for
Sep 14, 2023
Merged

feat(vitest): support vi.waitFor method#4113
sheremet-va merged 18 commits intovitest-dev:mainfrom
Dunqing:feat/wait-for

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented Sep 12, 2023

Description

Partial closes - #4061

The waitFor function was inspired by testing-library/web-testing-library#2.

Currently only supports timeout and interval options. I think this is enough, Let me know if you need to add any other options!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants