Skip to content

Conversation

@FTS427
Copy link

@FTS427 FTS427 commented Nov 30, 2025

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv6l-musl

depends="xkeyboard-config"
short_desc="Terminal emulator based on Kernel Mode Setting (KMS)"
maintainer="Orphaned <[email protected]>"
maintainer="Huang FTS427 <[email protected]>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the adoption. We would like to see maintainers establish a history of good stewardship before putting their names on packages.

@FTS427 FTS427 changed the title kmscon: update to 9.2.0, adopt. kmscon: update to 9.2.1, adopt. Dec 17, 2025
@ahesford
Copy link
Member

Please squash these commits down to one for libtsm and one for kmscon.

@FTS427 FTS427 force-pushed the kmscon_9.2.0_update branch from 747a416 to 86a6055 Compare January 1, 2026 08:34
@FTS427 FTS427 requested a review from ahesford January 1, 2026 08:34
depends="xkeyboard-config"
short_desc="Terminal emulator based on Kernel Mode Setting (KMS)"
maintainer="Orphaned <[email protected]>"
maintainer="Huang FTS427 <[email protected]>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was supposed to be dropped.


libtsm-devel_package() {
depends="${sourcepkg}>=${version}_${revision}"
depends="${makedepends} libtsm>=${version}_${revision}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ${sourcepkg} rather than libtsm as in the original.

Are both makedepends actually required by programs that link against this library? In particular, are they mentioned in a pkg-config descriptor included with this package?

@FTS427 FTS427 force-pushed the kmscon_9.2.0_update branch from 86a6055 to f2c77c4 Compare January 1, 2026 13:27
@ahesford
Copy link
Member

ahesford commented Jan 1, 2026

It seems you've folded most of the tsm update into the ksmcon commit.

@FTS427 FTS427 force-pushed the kmscon_9.2.0_update branch from f2c77c4 to c6261e0 Compare January 1, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants