Skip to content

feat(config): support task command shorthands#391

Open
jong-kyung wants to merge 8 commits into
voidzero-dev:mainfrom
jong-kyung:feat/task-command-shorthands
Open

feat(config): support task command shorthands#391
jong-kyung wants to merge 8 commits into
voidzero-dev:mainfrom
jong-kyung:feat/task-command-shorthands

Conversation

@jong-kyung
Copy link
Copy Markdown
Contributor

Summary

Closes #381.

Adds task command shorthands:

  • "build": "cmd"
  • "build": ["cmd1", "cmd2", ...]
  • { "command": ["cmd1", "cmd2", ...] }

Arrays reuse the existing && planning path, so cache behavior, dependsOn, and task options stay consistent. Empty arrays and empty/whitespace-only entries are rejected.

Allow task definitions to use command string and command array shorthands, and allow object-form command arrays to normalize through the existing && command planning path. Update generated config types, docs, changelog, and plan snapshots for the new syntax.
@jong-kyung
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_task_graph/src/config/user.rs Outdated
Comment thread crates/vite_task_graph/src/config/user.rs Outdated
Comment thread crates/vite_task_graph/src/config/user.rs Outdated
Comment thread crates/vite_task_graph/src/config/user.rs Outdated
Keep task command arrays as config data through graph loading and parse each array entry in the planner. This preserves quoting boundaries, supports nested vp runs and mixed && entries, and reports empty array entries during planning.
@jong-kyung jong-kyung marked this pull request as draft May 19, 2026 12:28
@jong-kyung
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32ded09d72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_task_plan/src/plan.rs Outdated
@jong-kyung
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc17f5041e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_task_plan/src/plan.rs Outdated
@jong-kyung
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jong-kyung jong-kyung marked this pull request as ready for review May 19, 2026 15:15
@jong-kyung
Copy link
Copy Markdown
Contributor Author

@branchseer I've addressed all of the suggested changes from your review and incorporated the feedback from Codex as well. Could you please review it again when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support task string shorthand and command string[] shorthand

2 participants