Bug fix: drain in-flight Feishu messages during shutdown - #902
Open
fy17ohhh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #901
Summary
Wire the AgentKit Feishu integration into
FeishuChannelExtension's lifecycle so that in-flight messages can finish during application shutdown.Previously, AgentKit maintained a separate background thread and called the wrapped SDK Channel's
start()andstop()methods directly. This bypassedFeishuChannelExtension.start()andshutdown(), so message tasks were not drained when the process receivedSIGTERM.Also rebinded lark_channel’s module-level WebSocket event loop to the dedicated Feishu worker loop before starting its synchronous client, preventing the
this event loop is already runningerror messageTesting
Behavior After This Change

The user can also receive the reply from Feishu bot with graceful shutdown now.