-
Notifications
You must be signed in to change notification settings - Fork 3k
[megatron] chore: clean legacy code path part 2, clean legacy CI #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on cleaning up legacy Megatron code paths and making mbridge the default, which is a positive step towards simplifying the codebase. The changes across documentation, shell scripts, and Python code are largely consistent with this goal. However, I've identified a critical issue in verl/models/mcore/registry.py where the logic for identifying Vision Language Models (VLMs) is flawed. This bug would cause VLMs to use an incorrect forward pass, breaking their functionality. I've provided suggestions to correct this. Please address these critical issues to ensure the new implementation works as expected for all model types.
| Get the forward function for given model architecture. | ||
| """ | ||
| assert len(hf_config.architectures) == 1, "Only one architecture is supported for now" | ||
| if hf_config.architectures[0] in SupportedVLM: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check hf_config.architectures[0] in SupportedVLM is incorrect. SupportedVLM is an Enum class, and this check will always evaluate to False because hf_config.architectures[0] is a string, not an enum member. This will cause Vision Language Models (VLMs) to be incorrectly treated as standard language models, leading to the use of the wrong forward function.
To fix this, you should check against the values of the enum members.
| if hf_config.architectures[0] in SupportedVLM: | |
| if hf_config.architectures[0] in {item.value for item in SupportedVLM}: |
| Get the forward function for given model architecture. | ||
| """ | ||
| assert len(hf_config.architectures) == 1, "Only one architecture is supported for now" | ||
| if hf_config.architectures[0] in SupportedVLM: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous comment, the check hf_config.architectures[0] in SupportedVLM is incorrect and will always evaluate to False. This will cause Vision Language Models (VLMs) to use the wrong fused forward function, as they will be misidentified as standard language models.
To fix this, you should check against the values of the enum members.
| if hf_config.architectures[0] in SupportedVLM: | |
| if hf_config.architectures[0] in {item.value for item in SupportedVLM}: |
What does this PR do?
this is one of a series PRs to clean the legacy megatron code path and make bridge the default path for megatron. #4496
This PR make clean CIs, including qwen2.5vl megatron, model merger, config converter
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)