Skip to content

[WIP] VariantGet expression#7256

Draft
AdamGS wants to merge 2 commits intodevelopfrom
adamg/variant-get
Draft

[WIP] VariantGet expression#7256
AdamGS wants to merge 2 commits intodevelopfrom
adamg/variant-get

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 2, 2026

Summary

Closes: #000

Testing

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will degrade performance by 23.77%

❌ 25 regressed benchmarks
✅ 1097 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 65.2 µs 73.5 µs -11.2%
Simulation take_search[(0.005, 0.1)] 251.7 µs 324.3 µs -22.41%
Simulation take_search[(0.005, 0.5)] 1.2 ms 1.5 ms -23.59%
Simulation take_search[(0.01, 0.05)] 147.2 µs 183.5 µs -19.78%
Simulation take_search[(0.01, 0.1)] 272.7 µs 345.3 µs -21.05%
Simulation take_search[(0.005, 1.0)] 2.3 ms 3.1 ms -23.77%
Simulation take_search[(0.01, 0.5)] 1.3 ms 1.6 ms -22.14%
Simulation take_search[(0.005, 0.05)] 135.8 µs 172.1 µs -21.09%
Simulation take_search[(0.01, 1.0)] 2.5 ms 3.3 ms -22.3%
Simulation take_search_chunked[(0.005, 0.5)] 1.5 ms 1.8 ms -16.96%
Simulation take_search[(0.1, 0.5)] 1.8 ms 2.2 ms -16.89%
Simulation take_search[(0.1, 0.1)] 391.4 µs 464.1 µs -15.67%
Simulation take_search_chunked[(0.005, 0.1)] 320 µs 381.5 µs -16.14%
Simulation take_search[(0.1, 0.05)] 217 µs 253.3 µs -14.33%
Simulation take_search_chunked[(0.005, 0.05)] 170.9 µs 201.5 µs -15.19%
Simulation take_search[(0.1, 1.0)] 3.5 ms 4.3 ms -17.08%
Simulation take_search_chunked[(0.005, 1.0)] 3 ms 3.6 ms -17.08%
Simulation take_search_chunked[(0.01, 0.5)] 1.6 ms 1.9 ms -15.92%
Simulation take_search_chunked[(0.01, 0.1)] 344.7 µs 406.2 µs -15.15%
Simulation take_search_chunked[(0.01, 0.05)] 184 µs 214.6 µs -14.26%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing adamg/variant-get (49c091e) with develop (13937c0)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/variant-get branch from c98dc87 to 44f1e3b Compare April 2, 2026 08:50
@AdamGS AdamGS added the changelog/feature A new feature label Apr 2, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/variant-get branch from 38345ea to 49c091e Compare April 2, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant