Skip to content

make struct_fields boxed, not arc'd#7257

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/ffi-box-leak
Apr 2, 2026
Merged

make struct_fields boxed, not arc'd#7257
myrrc merged 1 commit intodevelopfrom
myrrc/ffi-box-leak

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Apr 2, 2026

StructFields are Arc'd inside, so double Arc'ing it makes no sense.
Add C side tests for struct builder

@myrrc myrrc requested a review from joseph-isaacs April 2, 2026 10:09
@myrrc myrrc force-pushed the myrrc/ffi-box-leak branch from 618d37b to 40331b5 Compare April 2, 2026 10:09
@myrrc myrrc added the changelog/chore A trivial change label Apr 2, 2026
@myrrc myrrc enabled auto-merge (squash) April 2, 2026 10:10
Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc force-pushed the myrrc/ffi-box-leak branch from 40331b5 to 712c11d Compare April 2, 2026 10:15
@myrrc myrrc merged commit 13937c0 into develop Apr 2, 2026
57 of 58 checks passed
@myrrc myrrc deleted the myrrc/ffi-box-leak branch April 2, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants