Skip to content

feat[vortex-array]: support executing UUID to arrow#7266

Open
asubiotto wants to merge 1 commit intodevelopfrom
asubiotto/uuid
Open

feat[vortex-array]: support executing UUID to arrow#7266
asubiotto wants to merge 1 commit intodevelopfrom
asubiotto/uuid

Conversation

@asubiotto
Copy link
Copy Markdown
Contributor

Summary

Addresses: #6854

Testing

@asubiotto asubiotto requested a review from connortsui20 April 2, 2026 15:33
@asubiotto asubiotto added the changelog/feature A new feature label Apr 2, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will degrade performance by 21.71%

❌ 2 regressed benchmarks
✅ 1120 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation varbinview_zip_block_mask 2.9 ms 3.8 ms -21.71%
Simulation varbinview_zip_fragmented_mask 6 ms 7 ms -14.52%

Comparing asubiotto/uuid (7679cdc) with develop (38ab5af)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
@connortsui20
Copy link
Copy Markdown
Contributor

I think we need to decouple some of this logic. We can't have the arrow executor for an extension type that the core vortex crates don't know about exist there.

However, I think it does make sense to have an FSL<u8> executor into arrow FSB, and then the vector extension type can delegate to that.

CC @AdamGS as I remember you had some thoughts on how interop with arrow and our extension types should look like?

@joseph-isaacs
Copy link
Copy Markdown
Contributor

Surely we need to have a registry of exporter kernels?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants