PrimitiveArrayExt::narrow expose ExecutionCtx #8096
Merged
Merged
Conversation
Replace the internal LEGACY_SESSION.create_execution_ctx() in narrow with an explicit ExecutionCtx parameter, propagating it through dict_encode and dict_encode_with_constraints. This also removes the deprecated to_primitive calls inside narrow in favor of execute::<PrimitiveArray>(ctx). Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> https://claude.ai/code/session_01XumjWy7Gws28WbDfk9Z5pd
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.2 µs | 307.9 µs | -11.27% |
| ⚡ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
239.9 µs | 202.5 µs | +18.46% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/admiring-wright-yyvTE (0bb8d28) with develop (dbfe521)
Replace the LEGACY_SESSION usages introduced by this PR's test modules with a local `static SESSION: LazyLock<VortexSession>` defined per test module, so tests no longer depend on the global legacy session. Production code continues to use LEGACY_SESSION. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
robert3005
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow requires an exe ctx so pass one