fix: code coverage ci task#8142
Merged
Merged
Conversation
0ax1
force-pushed
the
fix-coverage-llvm-tools-check
branch
5 times, most recently
from
b935010 to
a6e72cb
Compare
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
force-pushed
the
fix-coverage-llvm-tools-check
branch
from
a6e72cb to
95d955b
Compare
0ax1
commented
May 28, 2026
|
|
||
| # Verify llvm-profdata is accessible (cargo-fuzz needs it for coverage merging) | ||
| LLVM_PROFDATA="$(rustc +$NIGHTLY_TOOLCHAIN --print sysroot)/lib/rustlib/$(rustc +$NIGHTLY_TOOLCHAIN -vV | sed -n 's|host: ||p')/bin/llvm-profdata" | ||
| RUST_SYSROOT="$(rustc +$NIGHTLY_TOOLCHAIN --print sysroot)" |
Contributor
Author
There was a problem hiding this comment.
Also changed to the more robust way to find the path here.
0ax1
commented
May 28, 2026
| run: | | ||
| set -euo pipefail | ||
| LLVM_TOOLS_BIN="$(dirname "$(rustup which llvm-profdata)")" | ||
| RUST_SYSROOT="$(rustc --print sysroot)" |
Contributor
Author
There was a problem hiding this comment.
set -euo pipefail is not needed. GH does set set -e.
robert3005
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installed LLVM tools reside under
which is different from what we previously expected.
Further, splitting up the commands like
leads to non-zero exit code in case any of them fail. This is unlike the previous setup where only the outermost command
dirnamewas checked for its exit code which is 0, even if""is passed as an argument.