Add third party cookie relaxations for FedCM #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiesinger
reviewed
Nov 30, 2023
yi-gu
reviewed
Nov 30, 2023
TallTed
reviewed
Nov 30, 2023
Collaborator
Author
|
Based on discussion, we will need #526 first before moving forward on this PR. |
npm1
commented
Sep 18, 2024
Collaborator
Author
npm1
left a comment
npm1
left a comment
There was a problem hiding this comment.
This is ready for another review, ptal
yi-gu
reviewed
Oct 7, 2024
| 1. If [=connected accounts set=] [=list/contains=] |triple|, return | ||
| [=compute the connection status/connected=]. | ||
| 1. Return [=compute the connection status/disconnected=]. | ||
| 1. Otherwise, if account| [=map/contains=] {{IdentityProviderAccount/approved_clients}}, |
| 1. Otherwise, if account| [=map/contains=] {{IdentityProviderAccount/approved_clients}}, | ||
| |account|'s {{IdentityProviderAccount/approved_clients}} [=list/contains=] |provider|'s | ||
| {{IdentityProviderConfig/clientId}}, and third party cookies are available for |idpOrigin| | ||
| on |rpOrigin|, return [=compute the connection status/connected=]. |
Collaborator
There was a problem hiding this comment.
Do you think we should call out that when connected is returned this way, UA should not create a connection here? It does say "Prompt the user to gather explicit intent to create an account" in step 3 from the link above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517
Preview | Diff