Conversation
- Enhanced InvocationBase and SourceBase classes to accept `execution_engine_opts` in methods like `iter_packets`, `as_table`, `flow`, `run`, and `run_async`. - Updated StatefulStreamBase and its subclasses to support `execution_engine_opts` in their method signatures and implementations. - Modified CachedPodStream, KernelStream, LazyPodResultStream, PodNodeStream, TableStream, and WrappedStream to propagate `execution_engine_opts` through their respective methods. - Updated RayEngine to handle function submission with engine-specific options. - Enhanced the Pipeline class to pass `execution_engine_opts` during node execution. - Updated core protocols to include `execution_engine_opts` in relevant method signatures for Pods and Streams. This change improves flexibility and configurability of execution engines across the Orcapod framework.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
brian-arnold
approved these changes
Nov 3, 2025
Collaborator
brian-arnold
left a comment
brian-arnold
left a comment
There was a problem hiding this comment.
Went through everything and I see where resource options ultimately are given to the ray decorated function. It's a much bigger update than I would have expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance various stream and source methods to accept
execution_engine_opts, improving the flexibility and configurability of execution engines within the Orcapod framework. This update includes modifications to core classes and protocols to support the new options.