Skip to content

docs(factories): add automation filters page - #551

Merged
hongyi-chen merged 3 commits into
hyc/factory-launchfrom
oz/factories-automation-filters
Aug 17, 2026
Merged

docs(factories): add automation filters page#551
hongyi-chen merged 3 commits into
hyc/factory-launchfrom
oz/factories-automation-filters

Conversation

@hongyi-chen

Copy link
Copy Markdown
Collaborator

Summary

Adds factories/automation-filters — the dedicated filters page requested in advait's review comment on #520. Filter behavior was previously scattered across seven pages in the launch stack with the matching semantics stated only on the Linear page and the routing-vs-access caveat repeated on five pages. This page consolidates:

  • Matching rules - every filter must match (AND), any value within a filter matches (OR), an empty filter matches everything, and one event can start multiple runs.
  • Filters route work; they don't restrict access - the canonical statement of the security boundary, with the per-provider authorization sources.
  • Per-source filter availability - a table linking each integration guide.
  • Filters in definitions as code - the filter key on triggers, reusing the verified example from the definitions-as-code page.
  • Edit filters on an automation - the control room procedure shared by every provider.

Also links to the new page from the two integration pages already merged into hyc/factory-launch (Slack authorization paragraph, Jira filter section) and adds the sidebar entry under Connect.

Dependencies and follow-ups

Validation

  • npm run typecheck: 0 errors
  • npm run build: 378 pages built (377 + this page); table renders, all internal links resolve, and the Slack/Jira pages link back
  • style_lint --changed: 0 issues in the new page; remaining flags are pre-existing warnings on untouched lines

Unverified claims

None introduced against product source directly — every behavior claim is consolidated verbatim-or-tighter from launch-stack pages that were themselves verified against source (Warp e72fd7aac, warp-server 9be39e484b per #520/#525/#528): matching semantics from the Linear (#527) and Jira pages, filter tables from the GitHub (#526) and GitLab (#549) pages, who-can-start-work from the GitHub/GitLab/Slack pages, the editor procedure from the Slack/GitHub pages, and the YAML example from the definitions-as-code page (#519).

Add a shared reference for automation filter matching rules, per-source
filter availability, the routing-vs-access boundary, and filters in
definitions as code. Link it from the Slack and Jira integration pages
and the Factories sidebar.

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Aug 17, 2026
@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 17, 2026 7:54pm

Request Review

Copy link
Copy Markdown
Collaborator Author

This PR was generated with Warp.

Comment @warp-agent on this PR to send it follow-up work.

View run View conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Your Warp account is not a member of any team with access to this repository.

@hongyi-chen
hongyi-chen requested a review from advait-m August 17, 2026 19:44
@hongyi-chen
hongyi-chen marked this pull request as ready for review August 17, 2026 19:44
@oz-for-oss

oz-for-oss Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@hongyi-chen

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

…ories-automation-filters

# Conflicts:
#	src/content/docs/factories/integrations/slack.mdx

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a dedicated factory automation filters page, links it from the Slack and Jira factory integration pages, and adds the page to the factories sidebar. The changed docs are consistent with the repository style guidance, the added MDX comment matches existing source-comment practice, and the diff does not introduce security-sensitive code or configuration.

Concerns

  • None.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@advait-m advait-m left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet thanks!

Align the new automation-filters page and its jira.mdx cross-link with
the root-absolute link convention adopted on hyc/factory-launch in #550.

Co-Authored-By: Warp <agent@warp.dev>

Copy link
Copy Markdown
Collaborator Author

Resolved the merge conflict with hyc/factory-launch and polished link style:

Validation: npm run typecheck 0 errors; npm run build succeeds with all internal links resolving in dist/; style_lint --changed reports only pre-existing unrecognized-term warnings for bolded UI element names, which follow the UI-element formatting rule.

@hongyi-chen
hongyi-chen merged commit b34470a into hyc/factory-launch Aug 17, 2026
4 checks passed
@hongyi-chen
hongyi-chen deleted the oz/factories-automation-filters branch August 17, 2026 19:55
hongyi-chen added a commit that referenced this pull request Aug 17, 2026
… and cross-page seams (#557)

* docs(factories): convert relative links to root-absolute on launch pages

Relative links resolve against the page's trailing-slash URL at runtime
(./x becomes /factories/<page>/x), so they 404 even though the file-based
CI link checker passes. #550 swept the pages merged before it; the pages
that landed after (#516 overview/how-it-works, #520 connect, #527 Linear)
reintroduced the pattern. Converts all of them to the repo's root-absolute
trailing-slash convention.

Co-Authored-By: Warp <agent@warp.dev>

* docs(factories): fix cross-page seams left by the stacked launch PRs

- Map the setup wizard's Code toggle to the Implement role (quickstart vs
  factory-agents used different names for the same role)
- Map lifecycle stage names to the Activity view's UI names (Planning,
  Building), which how-factories-work never connected
- Define a Factory MCP task as the factory's work item; the page used
  'task' throughout without bridging to the term the rest of the section
  uses
- Link connect-your-factory to the automation-filters page (#551 added
  the page after #520 merged, so the hub never referenced it)
- Align 'cancelled' spelling on the Jira page with the rest of the section
- Replace two 'cloud agent identity' usages with 'cloud agent' per the
  terminology glossary (platform/agents.mdx)

Co-Authored-By: Warp <agent@warp.dev>

---------

Co-authored-by: Warp <agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants