docs(factories): apply remaining Slack page review feedback - #552
Conversation
Add how-factories-work link, managed-apps model explanation, uninstall steps, and privacy section from PR #525 review. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the factory Slack integration documentation with a link to the factory overview, details about the managed-apps connection model, uninstall instructions, and a privacy section. I reviewed the documentation changes against the docs style guidance, existing Slack integration documentation, the supplied diff annotations, and the empty spec context; no blocking correctness, security, link, or structure issues surfaced.
Concerns
- No approved or repository spec context was provided, so there is no implementation-spec drift to assess.
- No inline concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Clears the conflict on #542 and applies the product answer on the handle. The base already had the #532 redirect collapse: someone merged main into hyc/factory-launch in 1c835b4 while PR #553 was being prepared, so the branch is at 1292 rules with 742 collapsed. #553 is closed as redundant. Three conflicts: - factories/connect-your-factory.mdx and infrastructure-and-security.mdx were STUB placeholders here, tokenized during the guard pass, and are now fully written on the base (#520-#552). Took the base version outright; the stubs no longer exist. - agents/getting-started/agents-in-warp.mdx was deleted upstream by #503 and only modified here by the article pass, so the deletion loses nothing. The redirect to /agents/ already ships. One fix the merge required: agents/index.mdx arrived with "Cloud agents run on [{VARS.WARP_AUTOMATION_PLATFORM}]" and no article. The determiner check caught it, which is the first time that rule has caught a regression coming *in* from another branch rather than one this work introduced. Mention handle: @oz -> @warp, 20 occurrences across 9 pages plus the glossary. Product confirmed today. These were deliberately hardcoded rather than tokenized back in #513, on the grounds that a handle is a literal string the product owns and variabilizing it would silently rewrite a working handle into an invalid one at rename time. That call is what made this a clean one-line-per-site change now: had they been tokenized, the 8/18 flip would already have turned every one of them into "@automation Platform" and the real answer would have arrived too late. The 48 `@oz-agent` GitHub handles are untouched and stay as they are; that is a different handle on a different service. Verified: no stale @oz outside the glossary's own historical note; style_lint 1124 against a 1148 baseline, hardcoded-var 0, determiner 0. Not build-verified locally -- local builds were taking long enough to be the bottleneck, so CI covers it. Co-Authored-By: Warp <agent@warp.dev>
2 participants
Follow-up to #525. Three review suggestions merged only partially; this adds the rest:
Conversation
Co-Authored-By: Warp agent@warp.dev