spec: editable prompt suggestions (#9842)#10232
spec: editable prompt suggestions (#9842)#10232lonexreb wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
github-actions
Bot
added
the
external-contributor
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This spec adds an insert-as-draft path for prompt suggestions while preserving the existing send-on-click behavior.
Concerns
- The affordance contract does not unambiguously require both the edit icon and modifier-click path, even though the PR body describes both.
- Existing draft handling is left for a future TECH decision, so implementation and acceptance tests can pick different behaviors.
- The telemetry category mapping needs a named source in the existing model to keep event payloads consistent and private.
Verdict
Found: 0 critical, 2 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| - **New: insert-as-draft.** Discoverable via either: | ||
| - A small "edit" icon next to the suggestion (preferred, low | ||
| friction). | ||
| - Modifier-click on the suggestion (Cmd-click / Ctrl-click). |
There was a problem hiding this comment.
| - B2. Insert-as-draft replaces the current agent-input contents | ||
| with the suggestion text. If the input already has user text, | ||
| show a one-time confirmation tooltip ("Replace existing | ||
| draft?") OR insert at the current caret position — TECH spec | ||
| picks one. |
There was a problem hiding this comment.
| - B6. Telemetry: emit a single `prompt_suggestion_inserted_as_draft` | ||
| event when the user takes the new affordance. No payload beyond | ||
| the suggestion category (e.g., "zero_state", "follow_up") — | ||
| never the suggestion text or the user's edited result. |
There was a problem hiding this comment.
💡 [SUGGESTION] Define how suggestion category maps to existing PromptSuggestion fields so implementers do not invent inconsistent categories or use text-derived values.
1 participant
Spec for #9842. New insert-as-draft affordance (edit icon + modifier-click) on each prompt suggestion. Inserts the text into the agent input without sending; user edits and submits manually. Existing send-on-click behavior preserved.
Closes (spec-only) #9842.