-
-
Notifications
You must be signed in to change notification settings - Fork 839
switch /wave/stream-file to use new modern streams (w/ flow control) and fix big ttfb streaming bug #3084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
switch /wave/stream-file to use new modern streams (w/ flow control) and fix big ttfb streaming bug #3084
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
47daad5
new RemoteFileStreamCommand using the new streaming primitives
sawka 1e81ec0
implement the non-remote file api side
sawka 2801510
switch the /wave/stream-file to the new modern streaming interface (w…
sawka 7162bc0
fix huge streaming bug... ttfb now fast as opposed to having the whol…
sawka c6da982
unset write deadlines for streaming
sawka 84037ad
fix notfound to be a 404, not a 500
sawka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Does Go's fmt.Sscanf return success when the format matches but trailing input remains unread?💡 Result:
Yes, Go's fmt.Sscanf returns success (n > 0 and err == nil) when the format matches and parses the expected values, even if trailing input remains unread. It does not require consuming the entire input string and only signals an error if the format fails to match or parsing fails.
Citations:
Reject trailing garbage in
ParseByteRange.fmt.Sscanfsucceeds when the format matches and parses the expected values, even if trailing input remains unread. This means inputs like0-99,200-299or0-99fooare silently accepted as0-99instead of being rejected, allowing unsupported or malformed byte range headers to pass validation.Suggested fix
🤖 Prompt for AI Agents