Skip to content

fix for terrible background color for default "ls" output on pwsh#3119

Merged
sawka merged 1 commit intomainfrom
sawka/fix-default-pwsh-ls-colors
Mar 25, 2026
Merged

fix for terrible background color for default "ls" output on pwsh#3119
sawka merged 1 commit intomainfrom
sawka/fix-default-pwsh-ls-colors

Conversation

@sawka
Copy link
Copy Markdown
Member

@sawka sawka commented Mar 25, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f7e8552c-fcbb-4239-8189-522255e02213

📥 Commits

Reviewing files that changed from the base of the PR and between 0ee1224 and 1c9e92a.

📒 Files selected for processing (1)
  • pkg/util/shellutil/shellintegration/pwsh_wavepwsh.sh

Walkthrough

A PowerShell shell integration script was modified to add a conditional statement that checks if the $PSStyle.FileInfo.Directory property matches a blue background ANSI escape sequence and reassigns it to a blue foreground escape sequence instead. This adjustment executes within the PowerShell 7+ version gate and before the shell integration's first prompt flag is enabled, affecting how directories are visually rendered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance or quality. Add a description explaining the issue being fixed, the solution approach, and any testing performed to validate the fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing a background color issue with PowerShell's default ls output.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sawka/fix-default-pwsh-ls-colors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot bot commented Mar 25, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)

Reviewed by minimax-m2.5-20260211 · 277,072 tokens

@sawka sawka merged commit 101d09b into main Mar 25, 2026
4 checks passed
@sawka sawka deleted the sawka/fix-default-pwsh-ls-colors branch March 25, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant